Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10812

to look at the new patch set (#3).

Change subject: [rebalance-test] fix running the test on Ubuntu 18.04
......................................................................

[rebalance-test] fix running the test on Ubuntu 18.04

Updated custom equality operators for TableBalanceInfo and
ClusterBalanceInfo.  With this update, the operator compares just the
contents of corresponding sub-fields of the ServersByCountMap type
(which is map<int32_t, string>), disregarding the order of elements for
the same key.  That's the exact behavior desired: the ordering of
elements in the ServersByCountMap is not important in all scenarios
of the rebalance-test.

The motivation for this change is the fact that the test fails on
Ubuntu 18.04 without this patch.  Implicitly, the reference results
relied on the order of elements in hash dictionary container used in
the implementation of the Rebalancer::KsckResultsToClusterBalanceInfo()
method.  It seems the implementation of std::unordered_map in libstdc++
shipped with Ubuntu 18.04 has changed compared with older Linux distro
versions.

Change-Id: Ie4dc5d22bab86f6ab61f18f05e45a063bbf38eba
---
M src/kudu/tools/rebalance-test.cc
1 file changed, 64 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/10812/3
--
To view, visit http://gerrit.cloudera.org:8080/10812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4dc5d22bab86f6ab61f18f05e45a063bbf38eba
Gerrit-Change-Number: 10812
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <[email protected]>

Reply via email to