Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10812 )
Change subject: [rebalance-test] fix running the test on Ubuntu 18.04 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) The test now passes on Ubuntu 18.04. Thanks! http://gerrit.cloudera.org:8080/#/c/10812/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10812/3//COMMIT_MSG@17 PS3, Line 17: The motivation for this change is the fact that the test fails on : Ubuntu 18.04 without this patch. Implicitly, the reference results : relied on the order of elements in hash dictionary container used in : the implementation of the Rebalancer::KsckResultsToClusterBalanceInfo() : method. It seems the implementation of std::unordered_map in libstdc++ : shipped with Ubuntu 18.04 has changed compared with older Linux distro : versions. FWIW, I changed all of the unordered_maps and unordered_sets in the tools/ directory to regular maps and sets, and the test still failed. If we're iterating on hashed containers, perhaps we should be using unhashed containers instead? Or do we need the O(1) lookups provided by the hashed containers? -- To view, visit http://gerrit.cloudera.org:8080/10812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4dc5d22bab86f6ab61f18f05e45a063bbf38eba Gerrit-Change-Number: 10812 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 16:55:06 +0000 Gerrit-HasComments: Yes
