Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10821 )
Change subject: consensus queue: Clarify return value of ResponseFromPeer() ...................................................................... Patch Set 1: (6 comments) looks good, just few nits http://gerrit.cloudera.org:8080/#/c/10821/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10821/1//COMMIT_MSG@9 PS1, Line 9: improvmenets improvements http://gerrit.cloudera.org:8080/#/c/10821/1//COMMIT_MSG@11 PS1, Line 11: anothe another http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue-test.cc@528 PS1, Line 528: bool send_more_immediately; : send_more_immediately = queue_->ResponseFromPeer(response.responder_uuid(), response); nit: combine definition and assignment http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue-test.cc@713 PS1, Line 713: send_more_immediately Indeed: is there any assertion needed for send_more_immediately here? http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue.cc@1033 PS1, Line 1033: bool send_more_immediately; nit: set to 'false' to use in the closest return: bool send_more_immediately = false; http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue.cc@1043 PS1, Line 1043: return false nit: return send_mode_immediately; -- To view, visit http://gerrit.cloudera.org:8080/10821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe73b5c69630898327ac7787e3dfcb0b761f323e Gerrit-Change-Number: 10821 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Jun 2018 03:38:54 +0000 Gerrit-HasComments: Yes
