Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10821 )
Change subject: consensus queue: Clarify return value of ResponseFromPeer() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/10821/1/src/kudu/consensus/consensus_queue-test.cc@713 PS1, Line 713: SetLastReceivedAndLas > Indeed: is there any assertion needed for send_more_immediately here? Ah, it seems it has been addressed in PS2 already. -- To view, visit http://gerrit.cloudera.org:8080/10821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe73b5c69630898327ac7787e3dfcb0b761f323e Gerrit-Change-Number: 10821 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Jun 2018 03:41:16 +0000 Gerrit-HasComments: Yes
