Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10809 )
Change subject: [python] : Add Pandas Support to Scanner ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10809/7/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10809/7/python/kudu/client.pyx@1883 PS7, Line 1883: by yielding results as requested. I think this doc needs to be more explicit -- it actually generates _batches_ of tuples, rather than generates tuples, right? if you wanted to generate all tuples, you'd need another layer of "for" loop down on 1889. Maybe this should be named generate_batches() or if you want to follow the python convention, 'xbatches()' or something to match xrange(), xreadlines(), etc? -- To view, visit http://gerrit.cloudera.org:8080/10809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90fab5c0c42448bcc17ea22be37420c6ef2f4915 Gerrit-Change-Number: 10809 Gerrit-PatchSet: 7 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 00:37:11 +0000 Gerrit-HasComments: Yes
