Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10880 )
Change subject: Read url-enconded hdfs path on restore ...................................................................... Patch Set 3: (3 comments) Looks good, just want some clarifications on comments. http://gerrit.cloudera.org:8080/#/c/10880/3//COMMIT_MSG Commit Message: PS3: IIUC, the patch ensures that the _table name_ is URL-encoded when resolved during restore; previously it wasn't. Yet, this commit message talks about the HDFS path. Could you clarify? http://gerrit.cloudera.org:8080/#/c/10880/3//COMMIT_MSG@7 PS3, Line 7: enconded encoded http://gerrit.cloudera.org:8080/#/c/10880/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/10880/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@44 PS3, Line 44: // Simulate an Impala table with special characters What's the effect of this override? What different code path is being tested? Could you add a little more detail to the comment? -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 3 Gerrit-Owner: Tony Foerster <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Jul 2018 17:58:14 +0000 Gerrit-HasComments: Yes
