Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/10880 )
Change subject: Read url-encoded table name on restore ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10880/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/10880/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@44 PS3, Line 44: test("Simple Backup and Restore") { > What's the effect of this override? What different code path is being teste The override seems unnecessary. I moved the impala table name string into a single test and added a comment -- To view, visit http://gerrit.cloudera.org:8080/10880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib028b9239c9e4aa71084757eb2dc16a3068de929 Gerrit-Change-Number: 10880 Gerrit-PatchSet: 4 Gerrit-Owner: Tony Foerster <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 18:59:56 +0000 Gerrit-HasComments: Yes
