Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50 PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class); > I noticed in your other patch that we sometimes prefer using "TestKuduMetas Which other patch? Not sure I understand. http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@79 PS1, Line 79: hiveTestDir.toFile().deleteOnExit(); // Ensure we cleanup state. > To make sure I understand, this doesn't happen at `tearDown()`, but when th When the JVM is exited. http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@100 PS2, Line 100: clientConf = new HiveConf(); > No longer used. My bad. I meant to put the usage back. -- To view, visit http://gerrit.cloudera.org:8080/10896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb Gerrit-Change-Number: 10896 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 10 Jul 2018 17:46:50 +0000 Gerrit-HasComments: Yes
