Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50 PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class); > Which other patch? Not sure I understand. Ah, nevermind. I was conflating Logger setup with table name setup. E.g. https://gerrit.cloudera.org/c/10838/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java#35 and https://gerrit.cloudera.org/c/10838/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java#47 -- To view, visit http://gerrit.cloudera.org:8080/10896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb Gerrit-Change-Number: 10896 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 10 Jul 2018 18:26:40 +0000 Gerrit-HasComments: Yes
