Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc
File src/kudu/rpc/rpcz_store.cc:

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc@252
PS1, Line 252:                    << call->header_.timeout_millis() << "ms).";
> How about using HumanReadableElapsedTime in human_readable.h?  Will make th
if so it would be nice to actually print it twice, like 12532ms (12.5sec) or 
something, since the non-human-readable form is a bit nicer for consumption by 
grep



--
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 19:03:40 +0000
Gerrit-HasComments: Yes

Reply via email to