Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10934 )
Change subject: hms-tool: filter non-Kudu tables in the HMS ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/10934/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10934/2//COMMIT_MSG@15 PS2, Line 15: The combination of these APIs : should be significantly more efficient than issuing a get for every : single table in the HMS and doing Kudu-side filtering. Sounds great. Is there anything you can measure to confirm the efficiency gain? http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_catalog-test.cc File src/kudu/hms/hms_catalog-test.cc: http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_catalog-test.cc@429 PS2, Line 429: hive::Table Nit: auto http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_catalog.cc@219 PS2, Line 219: const auto & Nit: const auto& http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/hms/hms_client.h@179 PS2, Line 179: // Retrieves HMS table metadata for many tables. Nit: how about "for all tables listed in 'table_names'", to be more precise? http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/tools/tool_action_hms.cc@a378 PS2, Line 378: : Nit: What do you have against passing smart pointers by cref? http://gerrit.cloudera.org:8080/#/c/10934/2/src/kudu/tools/tool_action_hms.cc@299 PS2, Line 299: isSynced Nit: since you're already in the area, this should be IsSynced. -- To view, visit http://gerrit.cloudera.org:8080/10934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f83d2e705ea6910a9aa0a1eda0d30b5feb2607b Gerrit-Change-Number: 10934 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 13 Jul 2018 00:03:47 +0000 Gerrit-HasComments: Yes
