Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10934 )
Change subject: hms-tool: filter non-Kudu tables in the HMS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10934/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/10934/1/src/kudu/hms/hms_catalog.cc@228 PS1, Line 228: Substitute("$0$1 = \"$2\"", does this support OR or IN predicates? If so, maybe we could make this twice as fast by avoiding the for loop above? -- To view, visit http://gerrit.cloudera.org:8080/10934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f83d2e705ea6910a9aa0a1eda0d30b5feb2607b Gerrit-Change-Number: 10934 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 12 Jul 2018 22:52:36 +0000 Gerrit-HasComments: Yes