Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10907 )
Change subject: Add support for running Java tests in dist-test ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@178 PS3, Line 178: os.path.join(ROOT, "build/lib/")] + > What is this directory? Isn't the build tree comprised of build/debug, buil This change is a carry over from Todds initial patch. I am not sure how build/lib is populated. http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@181 PS3, Line 181: # GTEST_OUTPUT must be canonicalized and have a trailing slash for gtest to : # properly interpret it as a directory. : test_logdir = os.path.abspath(os.path.join(ROOT, "build/test-logs")) : env['GTEST_OUTPUT'] = 'xml:' + test_logdir + '/' : env['TEST_LOGDIR'] = test_logdir > This is already set up for C++ tests in run-test.sh. Why do we need to dupl The Java tests don't use run-test.sh. I didn't make this change, It came from Todds original patch. But I think he simplified dis-test runs to use build/test-logs instead of build/<test-type>/test-log because we don't need to worry about test type collisions in dist-test. http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java File java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java: http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@65 PS3, Line 65: : String distTestBin = getProject().getRootDir() + "/../build-support/dist_test.py"; : : @OutputDirectory : File outputDir = new File(getProject().getBuildDir(), "dist-test"); : : List<Test> testTasks = Lists.newArrayList(); > private? Done http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@73 PS3, Line 73: public void testTask(Test t) { > Maybe addTestTask? This is called in the main build.gradle file. It doesn't need an annotation to be called because it public. http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@91 PS3, Line 91: if (fc == null) { : fc = t.getCandidateClassFiles(); : } else { : fc = fc.plus(t.getCandidateClassFiles()); : } > Maybe clearer as: I found a way to initialize an empty FileCollection which is more clear. http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@156 PS3, Line 156: // This hack replaces jars from the gradle cache in ~/.gradle/caches/... : // with jars copied under the project build directory. > As worded it sort of sounds like the hack will overwrite the files in ~/.gr Done http://gerrit.cloudera.org:8080/#/c/10907/3/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@255 PS3, Line 255: > Can you add class comments to these to explain why the layout is the way it Done -- To view, visit http://gerrit.cloudera.org:8080/10907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 Gerrit-Change-Number: 10907 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 16 Jul 2018 16:17:18 +0000 Gerrit-HasComments: Yes
