Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10907 )
Change subject: Add support for running Java tests in dist-test ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@41 PS3, Line 41: with open(os.path.join(ROOT, "build-support", "java-home-candidates.txt"), 'r') as candidates: > This is cribbed from cmake_modules/FindJavaHome.cmake, right? Can we share Done http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@178 PS3, Line 178: main() > This change is a carry over from Todds initial patch. I am not sure how bui I removed this. http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@179 PS3, Line 179: > Why do we need this glob? We Glob because the Java tests can't infer which build type we are using. http://gerrit.cloudera.org:8080/#/c/10907/3/build-support/run_dist_test.py@181 PS3, Line 181: : : : : > The Java tests don't use run-test.sh. I didn't make this change, It came fr I updated my patch to remove this and use the existing structure. -- To view, visit http://gerrit.cloudera.org:8080/10907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 Gerrit-Change-Number: 10907 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 16 Jul 2018 22:15:40 +0000 Gerrit-HasComments: Yes
