Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10956
Change subject: [logging] fix logging init if linking kudu client library ...................................................................... [logging] fix logging init if linking kudu client library Don't call constructor-like InitializeBasicLogging() function in non-exported builds of the kudu_client library. The rationale is simple: the non-exported kudu_client library is used in Kudu tools, benchmarks, and tests. In tools and benchmarks, InitGoogleLoggingSafe() is called to initialize the logging as needed. In tests, the gtest initializes glog on itself. Prior to this fix, the kudu CLI tool could exit on SIGPIPE when master/tserver abruptly closed connection. That's because the call to InitGoogleLoggingSafe() in the main() function of the CLI tool didn't do anything once InitGoogleLoggingSafeBasic() has been inadvertently called by the linked kudu_client library. Change-Id: I6dcd8d7ccb8a9cafa79674273b95c61eee5baf5a --- M src/kudu/client/client.cc M src/kudu/tools/tool_main.cc 2 files changed, 15 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10956/1 -- To view, visit http://gerrit.cloudera.org:8080/10956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6dcd8d7ccb8a9cafa79674273b95c61eee5baf5a Gerrit-Change-Number: 10956 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
