Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10956 )
Change subject: [logging] fix logging init if linking kudu client library ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10956/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10956/1//COMMIT_MSG@16 PS1, Line 16: Prior to this fix, the kudu CLI tool could exit on SIGPIPE when : master/tserver abruptly closed connection. > That isn't working -- the kudu CLI exits on signal 13 without this patch if And another observation -- that SO_NOSIGPIPE is just for macOS, not for Linux (just an observation after discussing it with Adar). -- To view, visit http://gerrit.cloudera.org:8080/10956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dcd8d7ccb8a9cafa79674273b95c61eee5baf5a Gerrit-Change-Number: 10956 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 17 Jul 2018 21:43:36 +0000 Gerrit-HasComments: Yes