Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10957 )
Change subject: mvn: Remove <relativePath/> from <parent> ...................................................................... Patch Set 2: Are you sure this change makes sense? I'm looking at the documentation for relativePath (http://maven.apache.org/ref/3.0/maven-model/maven.html): The relative path of the parent pom.xml file within the check out. If not specified, it defaults to ../pom.xml. Maven looks for the parent POM first in this location on the filesystem, then the local repository, and lastly in the remote repo. relativePath allows you to select a different location, for example when your structure is flat, or deeper without an intermediate parent POM. However, the group ID, artifact ID and version are still required, and must match the file in the location given or it will revert to the repository for the POM. This feature is only for enhancing the development in a local checkout of that project. Set the value to an empty string in case you want to disable the feature and always resolve the parent POM from the repositories. Default value is: ../pom.xml. Seems like an empty relativePath (what we already had) provides the behavior you want: fetch the parent POM from a repo rather than from a local directory. -- To view, visit http://gerrit.cloudera.org:8080/10957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e3a965912f02fe36b6686b803fa1803516fb6e3 Gerrit-Change-Number: 10957 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 04:59:02 +0000 Gerrit-HasComments: No
