Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10957 )

Change subject: mvn: Remove <relativePath/> from <parent>
......................................................................


Patch Set 2:

> I suppose, though it adds potential for a new foot-gun if the directory above 
> the Kudu source directory were to contain an errant pom.xml. Disabling this 
> "feature" altogether (via <relativePath/>) seems like the safer thing to do, 
> IDE behavior notwithstanding.

Yeah, I agree. And I guess I got "lucky" by making this change because the 
weird behavior is back, even with this. I guess I'm going to have to revert 
this change.

> If you're referring to the XML found at the beginning of the webpage, it's 
> just a schema. Every tag in it is empty. The default value really is 
> "../pom.xml".

Ah, gotcha.


--
To view, visit http://gerrit.cloudera.org:8080/10957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e3a965912f02fe36b6686b803fa1803516fb6e3
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Wed, 18 Jul 2018 02:19:09 +0000
Gerrit-HasComments: No

Reply via email to