Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 )
Change subject: KUDU-2507: use FBM for KuduMiniCluster ...................................................................... Patch Set 1: > Patch Set 1: > > hrm, I'm not sure I agree with this change. Shouldn't we use our most common > supported configuration for our tests? > > Maybe we are better off with some sort of Java system property that users can > use if they want to be able to run the Java tests some unsupported > environment? I agree with the sentiment, but at the same time, the point of Java tests isn't to test against the log block manager, but to test against some Kudu cluster. A system property sounds fine too though. -- To view, visit http://gerrit.cloudera.org:8080/10961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c2622d7049dacf7693e7f830fa022dd6c7d7274 Gerrit-Change-Number: 10961 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 18:43:41 +0000 Gerrit-HasComments: No
