Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 )
Change subject: KUDU-2507: use FBM for KuduMiniCluster ...................................................................... Patch Set 1: > Patch Set 1: > > > I agree with the sentiment, but at the same time, the point of Java tests > > isn't to test against the log block manager, but to test against some Kudu > > cluster. > > That's true. But, I'm afraid if we eventually make the minicluster more > consumable by external projects, people may write some integration tests that > actually insert non-trivial amounts of data into it (eg to test a query > engine) at which point the scalability/perf issues of the FBM may actually be > problematic. Ah, fair point. Adar actually helped get to the bottom of the underlying reason we were seeing these failures, which is that the KuduMiniCluster isn't honoring the TEST_TMPDIR environment variable, as we do in kudu_tools_test.cc. As such, the KMCs were being directed to some /tmp directory instead of the expected drive, which should have been one that supports hole punching. I pointed Grant at the issue, since he's familiar with the KMCs and the general area. -- To view, visit http://gerrit.cloudera.org:8080/10961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c2622d7049dacf7693e7f830fa022dd6c7d7274 Gerrit-Change-Number: 10961 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 17 Jul 2018 20:23:09 +0000 Gerrit-HasComments: No
