Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10968
to review the following change.
Change subject: memrowset: support iteration with is_deleted virtual column
......................................................................
memrowset: support iteration with is_deleted virtual column
This patch rounds out the MemRowSet changes for incremental backups.
Taken together, it is now possible to iterate on a specific time range and
to learn which rows were deleted during that time range.
The patch introduces a very basic concept of a "virtual column", defined as
a statically defined column with a name, type, and defaults. A Kudu
subsystem that wishes to interact with a virtual column needs to first
figure out if the projection includes it (via ColumnSchema::Equals()). When
projected, the virtual column's data will be entirely default; it's the
subsystem's responsibility to fill in something meaningful afterwards.
There's absolutely no robustness here. For example, there's currently
nothing stopping someone from creating a real column with the same name. It
remains to be seen how usable this bare-bones abstraction will be; so far
it's sufficient for the MemRowSet.
Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e
---
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
5 files changed, 106 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/10968/1
--
To view, visit http://gerrit.cloudera.org:8080/10968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e
Gerrit-Change-Number: 10968
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
