Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10968/3/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/10968/3/src/kudu/common/schema.h@412 PS3, Line 412: Boolean nit: Boolean column (reads like a typo to me, otherwise) http://gerrit.cloudera.org:8080/#/c/10968/3/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/10968/3/src/kudu/common/schema.cc@142 PS3, Line 142: $$IS_DELETED$$ This seems to imply that column names of the form $$FOO$$ are reserved for internal Kudu use. Did you do any research into common schemes for indicating reserved column names? http://gerrit.cloudera.org:8080/#/c/10968/3/src/kudu/common/schema.cc@144 PS3, Line 144: false /* is_nullable */ protip: if you instead use the syntax /* is_nullable= */ false, clang-tidy will validate the variable name against the declaration for you and warn if they don't match. -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 18:57:52 +0000 Gerrit-HasComments: Yes
