Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10962 )
Change subject: [java] Add extra info about using multiple clients ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@83 PS1, Line 83: . nit: not your fault, but comma http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@86 PS1, Line 86: It's generally : * not appropriate to use multiple client instances connected to the same : * cluster in a single application. nit: maybe move this before "Separate client instances should be..." and add a newline to separate the points we're making: * don't use multiple clients to point to the same cluster * if you really want multiple clients, adjust your resources http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2267 PS1, Line 2267: appropriately nit: It wasn't super obvious what "appropriately" meant here until I read the commit message, so maybe specify "to abide thread resource limits" or something? -- To view, visit http://gerrit.cloudera.org:8080/10962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34242862ee6d806b74d7717399e5fd0260dece89 Gerrit-Change-Number: 10962 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 18 Jul 2018 17:15:33 +0000 Gerrit-HasComments: Yes
