Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10962 )
Change subject: [java] Add extra info about using multiple clients ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@83 PS1, Line 83: . > nit: not your fault, but comma Done http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@85 PS1, Line 85: that > not from this changelist, but just a small nit: that --> when (take it with Done http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@86 PS1, Line 86: It's generally : * not appropriate to use multiple client instances connected to the same : * cluster in a single application. > nit: maybe move this before "Separate client instances should be..." and a Are you suggesting making those two points in a bulleted list? I really don't like that because the points aren't parallel. I reworked the section to be briefer. http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@91 PS1, Line 91: See the options in {@link AsyncKuduClientBuilder} > Maybe, it's worth pointing to KuduClientBuilder as well? The sync client and builder refer to their async counterparts for docs. http://gerrit.cloudera.org:8080/#/c/10962/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2267 PS1, Line 2267: appropriately > nit: It wasn't super obvious what "appropriately" meant here until I read t Done -- To view, visit http://gerrit.cloudera.org:8080/10962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34242862ee6d806b74d7717399e5fd0260dece89 Gerrit-Change-Number: 10962 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 16:55:24 +0000 Gerrit-HasComments: Yes
