Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 )
Change subject: memrowset: support iteration with snap_to_exclude ...................................................................... Patch Set 5: (3 comments) Nice test! http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.h@553 PS5, Line 553: // The 'unset_in_sel_vector' parameter will be overwritten if: : // - At least one mutation was relevant (will be set to false). : // - The last mutation walked was a DELETE (will be set to true). How about we call this 'selected' and reverse the negative semantics of this in-out param? http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.cc@507 PS5, Line 507: it : // means the insertion was outside this iterator's time range I think for the MRS this might not be an issue, but for DRS it likely may mean that snap_to_exclude is earlier than the ancient history mark and the corresponding insert UNDO record has been GCed, because base data does not have an insertion timestamp. I am not sure if that's relevant or not, because I haven't yet spent enough time thinking about how the DRS changes are going to interact with the APIs you're building in this patch series. http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.cc@608 PS5, Line 608: *unset_in_sel_vector = true; I'm assuming we're going to have to handle this differently when we get to the part about adding a 'deleted' virtual column. -- To view, visit http://gerrit.cloudera.org:8080/10926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9be2ab5af4d5223889e4545ae1db7cc0275480ce Gerrit-Change-Number: 10926 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 18:15:38 +0000 Gerrit-HasComments: Yes
