Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 )
Change subject: memrowset: support iteration with snap_to_exclude ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/10926/5/src/kudu/tablet/memrowset.cc@507 PS5, Line 507: it : // means the insertion was outside this iterator's time range > I think for the MRS this might not be an issue, but for DRS it likely may m After letting this observation marinate for a few minutes, I think it's expected behavior, because a request for a diff scan with snap_to_exclude < the AHM has a good chance of being impossible to respond to correctly. So it should be rejected, just like we reject scans with snap_to_include < AHM. -- To view, visit http://gerrit.cloudera.org:8080/10926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9be2ab5af4d5223889e4545ae1db7cc0275480ce Gerrit-Change-Number: 10926 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 18:35:45 +0000 Gerrit-HasComments: Yes
