Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc@632 PS2, Line 632: false /* is_key */ > Like I mentioned in the other review, /* is_key= */ has to come before the Done -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 22:37:07 +0000 Gerrit-HasComments: Yes
