Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset-test.cc@737 PS5, Line 737: } same comment about testing the case with reinserts, just for good measure http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset.h@594 PS5, Line 594: size_t projection_vc_is_deleted_idx_; shouldn't this be int? I think kColumnNotFound is -1 http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset.cc@404 PS5, Line 404: projection if projection is a schema, could we just use find_column here? http://gerrit.cloudera.org:8080/#/c/10990/5/src/kudu/tablet/memrowset.cc@562 PS5, Line 562: *reinterpret_cast<bool*>(dst_row.mutable_cell_ptr(projection_vc_is_deleted_idx_)) = true; Can you use UnalignedStore here instead? It compiles to the same thing but we've been trying to minimize reinterpret_cast usage after KUDU-2378 -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 22:57:29 +0000 Gerrit-HasComments: Yes
