Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 )
Change subject: hms-tool: refactor check tool and combine upgrade and fix ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/gutil/strings/escaping.h File src/kudu/gutil/strings/escaping.h: http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/gutil/strings/escaping.h@145 PS2, Line 145: return CUnescape(source, dest, nullptr); > warning: use nullptr [modernize-use-nullptr] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@78 PS2, Line 78: using std::pair; > warning: using decl 'map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@118 PS2, Line 118: shared_ptr<KuduClient> kudu_client; > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@153 PS2, Line 153: "Kudu table", > warning: parameter 'out' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@170 PS2, Line 170: "HMS database", > warning: parameter 'out' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@194 PS2, Line 194: DataTable table({ > warning: non-const reference parameter 'table_pairs', make it const or use Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@484 PS2, Line 484: // This most likely means the database doesn't exist, but it could be ambiguous. > warning: do not use 'else' after 'continue' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/11018/2/src/kudu/tools/tool_action_hms.cc@586 PS2, Line 586: return Status::RuntimeError("Failed to fix some catalog metadata inconsistencies"); > warning: do not use 'else' after 'return' [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/11018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee478002eb56a278cfd74255670baaf28109b8f Gerrit-Change-Number: 11018 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 24 Jul 2018 00:24:51 +0000 Gerrit-HasComments: Yes
