Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 )
Change subject: hms-tool: refactor check tool and combine upgrade and fix ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/11018/6/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11018/6/src/kudu/tools/tool_action_hms.cc@410 PS6, Line 410: " and consi > It's not possible to recreate a Kudu table from the information in the HMS, Ah, right. Sorry missed that. http://gerrit.cloudera.org:8080/#/c/11018/6/src/kudu/tools/tool_action_hms.cc@451 PS6, Line 451: nt; > I've reconfigured this somewhat. The tool now classifies tables with Hive One concern I have with this reconfiguration is in the 'upgrade' process. The cluster may have many Kudu tables with hive-incompatible names. Then the users need to figure out all of them and rename manually. http://gerrit.cloudera.org:8080/#/c/11018/6/src/kudu/tools/tool_action_hms.cc@532 PS6, Line 532: able (Kudu and HMS table > Good catch. I've inverted the control flow so that it upgrades the table i Cool. One thing to note here is as we discussed offline, it might be more clear to users if we group the fix that requires manual effort together in the analysis report of the 'check' tool. -- To view, visit http://gerrit.cloudera.org:8080/11018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee478002eb56a278cfd74255670baaf28109b8f Gerrit-Change-Number: 11018 Gerrit-PatchSet: 9 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 26 Jul 2018 22:35:49 +0000 Gerrit-HasComments: Yes
