Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10997 )
Change subject: KUDU-2509 fix use-after-free in case of WAL replay error ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/10997/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10997/4//COMMIT_MSG@9 PS4, Line 9: an > Nit: a Done http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc@699 PS4, Line 699: true > This is the default value, no? Also, don't we need a NO_FATALS() wrapper ar It's a good call. Indeed, that's necessary if we want to spot an error: I used just bland copy-paste technique in this place. I'll add an additional patch to correct that in other test scenarios in this test. http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc@707 PS4, Line 707: const auto schema = Schema({ ColumnSchema("key", INT32), > Can you refactor LogTestBase a bit so you don't need to redescribe schema_ I think it's not re-factoring LogTestBase just for this tiny thing. However, I updated the code of the test so now it's easy to follow the idea behind. http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc@728 PS4, Line 728: TxResultPB* result = mutate_commit->mutable_result(); : OperationResultPB* mutate = result->add_ops(); : MemStoreTargetPB* target = mutate->add_mutated_stores(); : target->set_mrs_id(1); > Maybe combine into one line? Done http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc@738 PS4, Line 738: result = insert_commit->mutable_result(); : OperationResultPB* insert = result->add_ops(); : target = insert->add_mutated_stores(); : target->set_mrs_id(1); > Combine this too? Done -- To view, visit http://gerrit.cloudera.org:8080/10997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11373b1cc34d9e2e0181bee2d3841b49022218ed Gerrit-Change-Number: 10997 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 24 Jul 2018 00:51:29 +0000 Gerrit-HasComments: Yes
