Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10997 )
Change subject: KUDU-2509 fix use-after-free in case of WAL replay error ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: http://gerrit.cloudera.org:8080/#/c/10997/4/src/kudu/tablet/tablet_bootstrap-test.cc@707 PS4, Line 707: const auto schema = Schema({ ColumnSchema("key", INT32), > I think it's not re-factoring LogTestBase just for this tiny thing. Howeve s/it's not re-factoring/it's not worth re-factoring/ -- To view, visit http://gerrit.cloudera.org:8080/10997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11373b1cc34d9e2e0181bee2d3841b49022218ed Gerrit-Change-Number: 10997 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 24 Jul 2018 00:52:24 +0000 Gerrit-HasComments: Yes
