Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11030 )

Change subject: Scala code formatting with Scalafmt
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties
File java/kudu-backup/out/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties@1
PS2, Line 1: # Licensed to the Apache Software Foundation (ASF) under one
> I don't think this file is supposed to be here.
Should we add the out directory to Kudu's .gitignore? i.e.

  java/**/out



--
To view, visit http://gerrit.cloudera.org:8080/11030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac96383d88394084e19712177d05f9fc63de766c
Gerrit-Change-Number: 11030
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Foerster <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Tue, 24 Jul 2018 17:02:11 +0000
Gerrit-HasComments: Yes

Reply via email to