Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 )
Change subject: Scala code formatting with Scalafmt ...................................................................... Patch Set 2: (3 comments) Thanks for the patch! Looks like mostly good changes to me, I'm not much of a Scala expert so I'll defer to Grant for the most part. http://gerrit.cloudera.org:8080/#/c/11030/2/java/.scalafmt.conf File java/.scalafmt.conf: http://gerrit.cloudera.org:8080/#/c/11030/2/java/.scalafmt.conf@2 PS2, Line 2: align = more > Given basically all of our cases statements aren't aligned today, could we +1 this setting is pretty aggressive http://gerrit.cloudera.org:8080/#/c/11030/2/java/.scalafmt.conf@9 PS2, Line 9: newlines.alwaysBeforeTopLevelStatements = true > Any thoughts on setting newlines.penalizeSingleSelectMultiArgList = false? Here is an example of what this setting can do: https://github.com/olafurpg/scala-repos/pull/14/files Personally I don't really think I'm a fan of true, there are a bunch of very "tall" call sites now, so I'd be mildly on the side of setting newlines.penalizeSingleSelectMultiArgList = false http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties File java/kudu-backup/out/test/resources/log4j.properties: http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties@1 PS2, Line 1: # Licensed to the Apache Software Foundation (ASF) under one > There us a .gitignore file at the java directory level we could use to igno OK -- To view, visit http://gerrit.cloudera.org:8080/11030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac96383d88394084e19712177d05f9fc63de766c Gerrit-Change-Number: 11030 Gerrit-PatchSet: 2 Gerrit-Owner: Tony Foerster <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 17:27:07 +0000 Gerrit-HasComments: Yes
