Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11058 )

Change subject: [docs] Add changing master hostnames workflow
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@663
PS1, Line 663: masters
new masters ?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@664
PS1, Line 664: resolve them
nit: missing period


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@670
PS1, Line 670: <tablet_id>
For this scenario, it's supposed to be 00000000000000000000000000000000 always, 
isn't it?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676
PS1, Line 676: new-master-name-1
Does it make sense to point that those names might be either FQDN or IP 
addresses?  And the recommended way is to use FQDNs for those, right?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679
PS1, Line 679: master_addresses
Does it make sense to mention that the '--rpc_bind_addresses' and 
'--webserver_interface' should be updated at the new hosts if any custom values 
were set?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@681
PS1, Line 681: tserver_master_addrs
Does it make sense to mention that the '--rpc_bind_addresses' and 
'--webserver_interface' should be updated at the new hosts if any custom values 
were set?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@684
PS1, Line 684: . Start up the masters.
Does it make sense to run some verification after this step?  Like 'kudu master 
list' or 'kudu master status'?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@686
PS1, Line 686: Start all of the tablet servers.
Does it make sense to run a verification step after that?  Say, 'sudo -u kudu 
kudu cluster ksck <master_addresses>'?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@696
PS1, Line 696: 
new-master-name-1.example.com,new-master-name-2.example.com,new-master-name-3.example.com
Maybe, make those match with the names used for Raft configuration change in 
the 'kudu local_replica cmeta rewrite_raft_config' command above?


http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@709
PS1, Line 709: ==== Verify the migration was successful
             :
             : To verify that all masters are working properly, perform the 
following sanity checks:
             :
             : * Using a browser, visit each master's web UI. Look at the 
/masters page. All of the masters should
             :   be listed there with one master in the LEADER role and the 
others in the FOLLOWER role. The
             :   contents of /masters on each master should be the same.
             :
             : * Run a Kudu system check (ksck) on the cluster using the `kudu` 
command line
             :   tool. See <<ksck>> for more details.
I think it make sense to do so prior to Impala and HMS-related changes.

BTW, I think it would make sense to add a verification step for the Impala+Kudu 
case as well.



--
To view, visit http://gerrit.cloudera.org:8080/11058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Jul 2018 20:58:40 +0000
Gerrit-HasComments: Yes

Reply via email to