Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 )
Change subject: [docs] Add changing master hostnames workflow ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@676 PS1, Line 676: new-master-name-1 > it should always be FQDN, with IPs Kerberos wouldn't work properly by defau I agree it should be FQDN here (for best practices's sake), and maybe it's better not to talk about IP addresses at all to avoid confusion, indeed. As for Kerberos-related restrictions, I'm not sure they are relevant for Raft config members, but that's not the point here anyway :) My point actually was: I didn't see FQDN is mentioned anywhere in the new section. Maybe, it's worth explicitly stating that all those new master names are FQDNs? Not short names, not IPs, not anything else. http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@679 PS1, Line 679: master_addresses > hostname change shouldn't affect that, unless they switch IP address as wel Right, that was my point -- if IP addresses changed, I though it would be nice to mention that other flags need to be updated as well. It seems my wording of '... any custom values ...' were set was confusing, sorry. http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@684 PS1, Line 684: . Start up the masters. > verification is suggested in a later step Right, but that was exactly my point here -- if just after migrating masters we can spot an error, that might be better because starting tablet servers takes some time and detecting a problem earlier makes it better localized. Do you think it's not worth it? http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@686 PS1, Line 686: Start all of the tablet servers. > verification is suggested in a later step Yep, indeed. http://gerrit.cloudera.org:8080/#/c/11058/1/docs/administration.adoc@696 PS1, Line 696: > Done All right -- it seems you decided to use short names in both cases. Then, maybe mention somewhere that those are supposed to be FQDNs? -- To view, visit http://gerrit.cloudera.org:8080/11058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03 Gerrit-Change-Number: 11058 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 27 Jul 2018 22:02:58 +0000 Gerrit-HasComments: Yes
