Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc File src/kudu/util/version_util-test.cc: http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc@33 PS2, Line 33: : TEST(VersionUtilTest, TestVersion) { : const vector<pair<Version, string>> good_test_cases = { > Would it make sense to add a small test that parses the current version of Sounds like a great idea! Done. http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h@39 PS2, Line 39: Return 'canonical' version string. > Hrm, how is this different than 'raw_version'? I think it's easier to point to those tests cases in version_util-test.cc: https://gerrit.cloudera.org/#/c/11060/2/src/kudu/util/version_util-test.cc@51 In short, leading and trailing whitespaces are trimmed, and SimpleItoa() has its own quirks in parsing the input. The 'canonical' version string is just concatenation of the parsed information back into a string. -- To view, visit http://gerrit.cloudera.org:8080/11060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf Gerrit-Change-Number: 11060 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 23:19:32 +0000 Gerrit-HasComments: Yes
