Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion() ...................................................................... [util] update on ParseVersion() This changelist updates implementation of the kudu::ParseVersion() utility function to recognize and successfully parse version strings like '1.8.0-cdh6.x-SNAPSHOT'. Version::ToString() implementation changed to return 'canonical' representation of the parsed version string. Added corresponding unit tests. This patch also fixes KUDU-2511. This is a follow-up for c12e63528a2f2c265136e702a48cbc6c93b7f2fd. Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf Reviewed-on: http://gerrit.cloudera.org:8080/11060 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/util/version_util-test.cc M src/kudu/util/version_util.cc M src/kudu/util/version_util.h 3 files changed, 98 insertions(+), 30 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf Gerrit-Change-Number: 11060 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]>
