Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 )
Change subject: hms-tool: refactor check tool and combine upgrade and fix ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/11018/10/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11018/10/src/kudu/tools/tool_action_hms.cc@169 PS10, Line 169: PrintTables It looks like PrintKuduTables can also be embedded into this function? http://gerrit.cloudera.org:8080/#/c/11018/10/src/kudu/tools/tool_action_hms.cc@366 PS10, Line 366: Suggestion: rename the Kudu table(s) to be Hive-compatible: Should we call out this needs to be run before running the fix tool. I am good with not doing it as long as we point out in the user guide doc. http://gerrit.cloudera.org:8080/#/c/11018/10/src/kudu/tools/tool_action_hms.cc@415 PS10, Line 415: "Suggestion: use the fix tool to repair the Kudu and Hive Metastore catalog metadata" : << endl nit: this can be put upfront L408 to avoid dup code. -- To view, visit http://gerrit.cloudera.org:8080/11018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee478002eb56a278cfd74255670baaf28109b8f Gerrit-Change-Number: 11018 Gerrit-PatchSet: 10 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 27 Jul 2018 23:08:14 +0000 Gerrit-HasComments: Yes
