Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master ...................................................................... hms-tool: lookup master addresses config from master The HMS check and fix tools currently use the master addresses configuration provided on the command line to validate and fix metadata in HMS table entries. This only works correctly if the administrator inputs the master addresses exactly as its configured on the masters. If the hostports are reordered or use a slightly different format which resolves to the same addresses, then metadata will be flagged as stale and rewritten unnecessarily. As an example, the administrator could pass 'localhost' as the master address if they ran it on the master node, but this wouldn't be appropriate to write into the HMS. This commit changes the handling so that the tools use the master addresses returned from the ConnectToCluster mechanism already present in the client, which should match the master addresses config of the master exactly. Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec Reviewed-on: http://gerrit.cloudera.org:8080/11083 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client.h M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc 6 files changed, 57 insertions(+), 24 deletions(-) Approvals: Kudu Jenkins: Verified Dan Burkert: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec Gerrit-Change-Number: 11083 Gerrit-PatchSet: 9 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins
