Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 )
Change subject: hms-tool: lookup master addresses config from master ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11083/3//COMMIT_MSG@14 PS3, Line 14: then metadata will be flagged as stale : and rewritten unnecessarily. > OK, what metadata specifically? Can you provide an example? Sure, Kudu writes the master addresses config into the table entry in the HMS under the 'kudu.master_addresses' key. The 'hms check' tool validates that the master address passed on the command line matches that property on all Kudu tables in the HMS. If any do not, the 'hms fix' tool will overwrite the property with the (assumed correct) value provided on the command line. If that value is wrong (e.g. the admin used 'localhost' because they knew they were on the master machine), then the HMS metadata will no longer be correct. The 'check' tool would have also unnecessarily flagged that table as having stale metadata. This commit changes the behavior so that the master addresses provided on the command line are not assumed correct, instead we assume that master's version of the master addresses config is correct. -- To view, visit http://gerrit.cloudera.org:8080/11083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If170cebe6e5d7fa05fbd7faf18755aa57bdfeeec Gerrit-Change-Number: 11083 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 31 Jul 2018 00:17:48 +0000 Gerrit-HasComments: Yes
