Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10990

to look at the new patch set (#8).

Change subject: memrowset: support iteration with is_deleted virtual column
......................................................................

memrowset: support iteration with is_deleted virtual column

This patch rounds out the MemRowSet changes for incremental backups.
Taken together, it is now possible to iterate on a specific time range and
to learn which rows were deleted during that time range.

Data type based virtual columns show a wart here: the iterator doesn't know
whether IS_DELETED was defined as nullable or with a read default value, and
it must be prepared for either. We could require one or the other, but that
pokes a hole in the abstraction of a virtual column as just a data type,
which seems undesirable.

Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8
---
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
3 files changed, 135 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/10990/8
--
To view, visit http://gerrit.cloudera.org:8080/10990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8
Gerrit-Change-Number: 10990
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to