Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11107 )
Change subject: [tools] run rebalancer during 'election storm' ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2072 PS1, Line 2072: : RebalancingTest() { > warning: initializer for base class 'kudu::tools::RebalancingTest' is redun Done http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2086 PS1, Line 2086: #if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) : const auto timeout = MonoDelta::FromSeconds(5); : #else : const auto timeout = MonoDelta::FromSeconds(10); > I think you swapped the timeouts here because the sanitizer builds should h The timeout here is a time-to-run for the stormy elector thread as well. So no, I didn't swapped those. Making longer timeout for workload in case of TSAN/ASAN is not needed -- the code is written to tolerate timeouts, if any: having everything generated written into the tables is not required. http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2093 PS1, Line 2093: auto max_sleep_ms = 2.0; > Can you explain where this number comes from? Obviously it's super low comp It was the lowest possible to be used in module expression. http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2109 PS1, Line 2109: for (const auto& tablet : tablets) { > With RF=3, running over each TS and replica will cause 3 elections to be ca Yes, that's what I want -- no matter how, but initiate as much elections as possible, but implemented with easy to follow code. http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2164 PS1, Line 2164: usually happens because GetConsensusState requests are dropped due to : // backpressure > As you mentioned to me in person, we should fix ksck to be resilient to thi We should, and as soon as it's done in a separate changelist, I'm thinking to update this part. -- To view, visit http://gerrit.cloudera.org:8080/11107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98684dbe55049bbc411513faa0b6bbaef20f434 Gerrit-Change-Number: 11107 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 20:53:26 +0000 Gerrit-HasComments: Yes
