Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11107 )
Change subject: [tools] run rebalancer during 'election storm' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2086 PS1, Line 2086: #if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) : const auto timeout = MonoDelta::FromSeconds(5); : #else : const auto timeout = MonoDelta::FromSeconds(10); > The timeout here is a time-to-run for the stormy elector thread as well. S (thumbsup) http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2093 PS1, Line 2093: auto max_sleep_ms = 2.0; > It was the lowest possible to be used in module expression. What do you mean by "module expression"? http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2109 PS1, Line 2109: for (const auto& tablet : tablets) { > Yes, that's what I want -- no matter how, but initiate as much elections as (thumbsup) http://gerrit.cloudera.org:8080/#/c/11107/1/src/kudu/tools/kudu-admin-test.cc@2164 PS1, Line 2164: usually happens because GetConsensusState requests are dropped due to : // backpressure > We should, and as soon as it's done in a separate changelist, I'm thinking (thumbsup) -- To view, visit http://gerrit.cloudera.org:8080/11107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98684dbe55049bbc411513faa0b6bbaef20f434 Gerrit-Change-Number: 11107 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 21:28:35 +0000 Gerrit-HasComments: Yes
