zhangqianqiong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11111 )
Change subject: KUDU-2525: KuduTableInputFormat may halt before exhausting scan ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11111/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11111/1//COMMIT_MSG@7 PS1, Line 7: KUDU-2525: KuduTableInputFormat may halt before exhausting scan > Rewrite as: Done http://gerrit.cloudera.org:8080/#/c/11111/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java: http://gerrit.cloudera.org:8080/#/c/11111/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java@66 PS1, Line 66: * This input format generates one split per tablet and the only location for each split is that > Given that there's one split per tablet, how does this bug manifest? I thou I can be sure that there is not an empty tablet in the table. scanner.nextRows() sometimes returned an empty RowResultIterator, and sometimes returned a normal RowResultIterator. In other words, the results is random. So, I guess that the scan is too time-consuming to timeout and returned the empty RowResultIerator http://gerrit.cloudera.org:8080/#/c/11111/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java@448 PS1, Line 448: // TODO(qqzhang) scanner.nextRows() sometimes returns an empty RowResultIterator, > Typically we mark things like this with TODO(...); what's left to do here? Done -- To view, visit http://gerrit.cloudera.org:8080/11111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbfdd2efbd281e4d849917664b33e183e180bafd Gerrit-Change-Number: 11111 Gerrit-PatchSet: 2 Gerrit-Owner: zhangqianqiong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: zhangqianqiong <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 02:45:11 +0000 Gerrit-HasComments: Yes
