Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11111 )
Change subject: KUDU-2525: KuduTableInputFormat may halt before exhausting scan ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11111/3/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java: http://gerrit.cloudera.org:8080/#/c/11111/3/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java@447 PS3, Line 447: try { Some other cosmetic suggestions: 1. Rewrap the comment to adhere to Kudu's 80 character soft limit (https://kudu.apache.org/docs/contributing.html#_line_length) 2. There is whitespace at the end of each row; gerrit flagged this with red. 3. The convention for TODO comments is to include an appropriate JIRA if there is one, or just your name if not. So "TODO(qqzhang): is better than just "TODO:". -- To view, visit http://gerrit.cloudera.org:8080/11111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbfdd2efbd281e4d849917664b33e183e180bafd Gerrit-Change-Number: 11111 Gerrit-PatchSet: 3 Gerrit-Owner: zhangqianqiong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: zhangqianqiong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 22:19:58 +0000 Gerrit-HasComments: Yes
