Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/10968/14/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10968/14/src/kudu/master/catalog_manager.cc@1324 PS14, Line 1324: Status s = TypeEncodingInfo::Get(ti, col.attributes().encoding, &dummy); You don't need to fix this in this patch since you didn't make it, but I don't like this validation style. Maybe we should add an isValid method instead of trying to get an instance of TypeEncodingInfo we don't use. http://gerrit.cloudera.org:8080/#/c/10968/14/src/kudu/master/catalog_manager.cc@1330 PS14, Line 1330: if (ti->is_virtual()) { Nit: Move this check above the encoding check since this is a more significant error and fixing encoding issues would just lead to this. http://gerrit.cloudera.org:8080/#/c/10968/14/src/kudu/master/catalog_manager.cc@1332 PS14, Line 1332: "may not create virtual column of type '$0'", ti->name())); Maybe include the column name too? -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 14 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 17:33:10 +0000 Gerrit-HasComments: Yes
