Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@158 PS11, Line 158: static bool IsVirtual() { : return false; : } > Is that possible? I thought the DataTypeTraits template was intentionally e Woops, I see. That would be possible if not those exact type-coded references like TypeTraitsClass::min_value() and alike. But it seems that was designed to be like this. http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@673 PS11, Line 673: case IS_DELETED: > As another point of evidence, Clang doesn't warn for statement-less cases, That makes sense. I thought the code style just mandates having those FALLTHROUGH_INTENDED. -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 11 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 20:08:45 +0000 Gerrit-HasComments: Yes
