Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11115 )
Change subject: [location_awareness] Assign locations to registering tablet servers ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11115/3/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11115/3/src/kudu/master/ts_descriptor.cc@224 PS3, Line 224: ResolveSockaddr > 1) and 2) are valid points, but they don't apply strictly to this patch. Th Last time I checked, tablet servers can be run with multiple RPC addresses, and those are recorded in a tablet server registration. What do you mean 'don't support multiple RPC addresses for a node'? Probably, that's outside of the scope of this patch, but my concern is not about batch registration process, rather what happens if tablet server 'moves' from location to another because of multiple DNS records. There might be an inconsistencies due to that (e.g., the rebalancer tool might be confused with that). Probably, we can have a separate tool which would run some diagnostics to figure out whether the location assignment is 'flaky'. -- To view, visit http://gerrit.cloudera.org:8080/11115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eb98823ab7b3b8141b8630196c29c1ebf8e6878 Gerrit-Change-Number: 11115 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 18:46:07 +0000 Gerrit-HasComments: Yes
