Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11135 )
Change subject: [Java] Update readme with Gradle commands ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/11135/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11135/1//COMMIT_MSG@17 PS1, Line 17: - Uses the sources distribution in the wrapper So now we'll download the wrapper's source artifact in addition to the binary itself? Why is this useful for intellij? http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc File java/README.adoc: http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@51 PS1, Line 51: The unit tests will start master and a tablet : servers using the flags file located in the `src/test/resources/` : directory. This isn't true anymore. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@74 PS1, Line 74: the tests ran. Can you provide a single-test example here, since that's likely to be a common use case? http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@87 PS1, Line 87: === Clearing Cached Build State May want to explain (in short) what Gradle caches, so that anyone reading this will understand under what circumstances it would make sense to clear the caches. http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@111 PS1, Line 111: == Building with Maven Do we want to make a stronger statement about Maven deprecation? http://gerrit.cloudera.org:8080/#/c/11135/1/java/README.adoc@113 PS1, Line 113: Though the Gradle build is becoming the preferred way to build, : the Maven build still exists and can be used. Trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/11135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I349ac7259beb1f6b80b80265803a06ec532019d7 Gerrit-Change-Number: 11135 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 03:13:30 +0000 Gerrit-HasComments: Yes
